Fix calculation of cop department for nested departments #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue I ran into with rubocop-i18n. This gem provides two nested departments, I18n/RailsI18n and I18n/GetText. The intent is to enable one and disable the other. However, disabling a department would not disable its cops. I tracked this issue down to how RuboCop::Config calculates a cops department before looking at that department's configuration: It only considers the part before the first `/`. This commit changes this method by considering instead all parts before the last `/`.
mvz
force-pushed
the
fix-disabling-nested-departments
branch
from
aae0cab
to
aad4c7a
Compare
|
The changes seem reasonable to me. I'll cc here @dmytro-savochkin as well as he worked on this in #8490 |
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I ran into with rubocop-i18n. This gem provides two nested departments, I18n/RailsI18n and I18n/GetText. The intent is to enable one and disable the other. However, disabling a department would not disable its cops.
I tracked this issue down to how RuboCop::Config calculates a cops department before looking at that department's configuration: It only considers the part before the first
/.This pull request changes this method by considering instead all parts before the last
/.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.