Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in Style/ExplicitBlockArgument #8826

Merged
merged 1 commit into from Oct 1, 2020
Merged

Fix crash in Style/ExplicitBlockArgument #8826

merged 1 commit into from Oct 1, 2020

Conversation

ghiculescu
Copy link
Contributor

Fixes #8825

@ghiculescu ghiculescu force-pushed the explicit_block_argument-crash branch from 9bfcf78 to 7d87fea Compare October 1, 2020 18:42
@ghiculescu ghiculescu marked this pull request as ready for review October 1, 2020 18:44
@ghiculescu ghiculescu mentioned this pull request Oct 1, 2020
Closed
@koic
Copy link
Member

koic commented Oct 1, 2020

Nice! Can you add the changelog entry to the bug fixes section of CHANGELOG.md and add your account to the bottom of the changelog as [@ghiculescu]: https://github.com/ghiculescu.?
https://github.com/rubocop-hq/rubocop/blob/master/CONTRIBUTING.md#changelog-entry-format

koic
koic reviewed Oct 1, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ghiculescu
Copy link
Contributor Author

I can squash, but out of curiosity why not use the github merge option that squashes for you?

@ghiculescu ghiculescu force-pushed the explicit_block_argument-crash branch from d93d10e to 8d91e98 Compare October 1, 2020 19:35
@koic
Copy link
Member

koic commented Oct 1, 2020

Great thanks!

I can squash, but out of curiosity why not use the github merge option that squashes for you?

Of course I can use squash merge, but personally I'd like to create a merge commit if possible. Because changing the commit hash can increase the cost of tracing for maintenance. There are several different options of thinking about this, and I don't want to spend as time on this subject as possible. Anyway, I'm glad that it will be improved. Thank you for taking your time 😅

@koic koic merged commit d797bde into rubocop:master Oct 1, 2020
@ghiculescu ghiculescu deleted the explicit_block_argument-crash branch October 1, 2020 19:58
@ghiculescu
Copy link
Contributor Author

No worries. Thanks for the explanation and for merging!

@koic koic mentioned this pull request Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in Style/ExplicitBlockArgument
2 participants
@ghiculescu @koic