Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Rakefile.rb from Naming/FileName check #12816

Merged
merged 1 commit into from Apr 7, 2024

Conversation

artur-intech
Copy link
Contributor

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 3, 2024

Don't forget to add a changelog entry as well.

@artur-intech
Copy link
Contributor Author

Don't forget to add a changelog entry as well.

Done! Thank you for reminding.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 5, 2024

The CI is failing, because the changelog entry name doesn't match the expected format.

@koic
Copy link
Member

koic commented Apr 7, 2024

Can you squash your commits into one?

@artur-intech
Copy link
Contributor Author

artur-intech commented Apr 7, 2024

Can we use Github's "Squash and merge" button? I didn't do it since I assumed we gonna use it.

@koic
Copy link
Member

koic commented Apr 7, 2024

I apologize, but I don't wish to spend time discussing this topic. For more details, please refer to the following. Thank you.
#8826 (comment)

@koic koic merged commit f0e475a into rubocop:master Apr 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants