Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8730] Fix an error for Lint/UselessTimes #8733

Merged
merged 1 commit into from Sep 16, 2020

Conversation

koic
Copy link
Member

@koic koic commented Sep 16, 2020

Fixes #8730.

This PR fixes an error for Lint/UselessTimes when there is a blank line in the method definition.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#8730.

This PR fixes an error for `Lint/UselessTimes`
when there is a blank line in the method definition.
@dvandersluis
Copy link
Member

Thanks @koic! Sorry I missed that.

@koic
Copy link
Member Author

koic commented Sep 16, 2020

@dvandersluis No problem. It is difficult to comprehensively cover how to use Ruby 😅

@koic koic merged commit 5e2acf3 into rubocop:master Sep 16, 2020
@koic koic deleted the fix_error_for_lint_useless_times branch September 16, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred while Lint/UselessTimes cop was inspecting
2 participants