Merge pull request #8733 from koic/fix_error_for_lint_useless_times

[Fix #8730] Fix an error for `Lint/UselessTimes`

CHANGELOG.md

@@ -7,6 +7,7 @@
 * [#8720](https://github.com/rubocop-hq/rubocop/issues/8720): Fix an error for `Lint/IdentityComparison` when calling `object_id` method without receiver in LHS or RHS. ([@koic][])
 * [#8710](https://github.com/rubocop-hq/rubocop/issues/8710): Fix a false positive for `Layout/RescueEnsureAlignment` when `Layout/BeginEndAlignment` cop is not enabled status. ([@koic][])
 * [#8726](https://github.com/rubocop-hq/rubocop/issues/8726): Fix a false positive for `Naming/VariableNumber` when naming multibyte character variable name. ([@koic][])
+* [#8730](https://github.com/rubocop-hq/rubocop/issues/8730): Fix an error for `Lint/UselessTimes` when there is a blank line in the method definition. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/lint/useless_times.rb

@@ -82,7 +82,12 @@ def autocorrect_block(corrector, node)
         def fix_indentation(source, range)
           # Cleanup indentation in a multiline block
           source_lines = source.split("\n")
-          source_lines[1..-1].each { |line| line[range] = '' }
+
+          source_lines[1..-1].each do |line|
+            next if line.empty?
+
+            line[range] = ''
+          end
           source_lines.join("\n")
         end
 

spec/rubocop/cop/lint/useless_times_spec.rb

@@ -61,6 +61,27 @@
     RUBY
   end
 
+  it 'registers an offense and corrects when there is a blank line in the method definition' do
+    expect_offense(<<~RUBY)
+      def foo
+        1.times do
+        ^^^^^^^^^^ Useless call to `1.times` detected.
+          bar
+
+          baz
+        end
+      end
+    RUBY
+
+    expect_correction(<<~RUBY)
+      def foo
+        bar
+
+        baz
+      end
+    RUBY
+  end
+
   it 'does not register an offense for an integer > 1' do
     expect_no_offenses(<<~RUBY)
       2.times { |i| puts i }