Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/ClassAndModuleChildren #8660

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -15,6 +15,7 @@
* [#8653](https://github.com/rubocop-hq/rubocop/pull/8653): Fix a false positive for `Layout/DefEndAlignment` when using refinements and `private def`. ([@koic][])
* [#8655](https://github.com/rubocop-hq/rubocop/pull/8655): Fix a false positive for `Style/ClassAndModuleChildren` when using cbase class name. ([@koic][])
* [#8654](https://github.com/rubocop-hq/rubocop/pull/8654): Fix a false positive for `Style/SafeNavigation` when checking `foo&.empty?` in a conditional. ([@koic][])
* [#8660](https://github.com/rubocop-hq/rubocop/pull/8660): Fix a false positive for `Style/ClassAndModuleChildren` when using cbase module name. ([@koic][])

### Changes

Expand Down
3 changes: 2 additions & 1 deletion lib/rubocop/cop/style/class_and_module_children.rb
Expand Up @@ -32,7 +32,6 @@ class ClassAndModuleChildren < Base
'nested style.'

def on_class(node)
return if node.identifier.children[0]&.cbase_type?
return if node.parent_class && style != :nested

check_style(node, node.body)
Expand Down Expand Up @@ -113,6 +112,8 @@ def indent_width
end

def check_style(node, body)
return if node.identifier.children[0]&.cbase_type?

if style == :nested
check_nested_style(node)
else
Expand Down
7 changes: 7 additions & 0 deletions spec/rubocop/cop/style/class_and_module_children_spec.rb
Expand Up @@ -67,6 +67,13 @@ class ::Foo
RUBY
end

it 'accepts cbase module name' do
expect_no_offenses(<<~RUBY)
module ::Foo
end
RUBY
end

it 'accepts :: in parent class on inheritance' do
expect_no_offenses(<<~RUBY)
class FooClass
Expand Down