Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/ClassAndModuleChildren #8660

Merged

Commits on Sep 7, 2020

  1. Fix a false positive for Style/ClassAndModuleChildren

    This PR fixes the following incorrect auto-correct for `Style/ClassAndModuleChildren`
    when using cbase module name.
    
    ```console
    % cat example.rb
    module ::Fixtures
    end
    
    % bundle exec rubocop -A --only Style/ClassAndModuleChildren example.rb
    (snip)
    
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:1:8: C: [Corrected] Style/ClassAndModuleChildren: Use nested
    module/class definitions instead of compact style.
    module ::Fixtures
           ^^^^^^^^^^
    
    1 file inspected, 1 offense detected, 1 offense corrected
    
    % cat example.rb
    module
      module Fixtures
      end
    end
    
    % ruby -c example.rb
    example.rb:3: syntax error, unexpected '\n', expecting '.' or &. or ::
    or '['
    ```
    koic committed Sep 7, 2020
    Copy the full SHA
    0408e2a View commit details
    Browse the repository at this point in the history