Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8518] Fix Lint/ConstantResolution cop reporting offense for module and class definitions #8542

Merged
merged 1 commit into from Aug 19, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #8518


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 18, 2020

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

…e for `module` and `class` definitions

Closes rubocop#8518
@tejasbubane
Copy link
Contributor Author

Rebased @bbatsov

@koic koic merged commit 75365cd into rubocop:master Aug 19, 2020
@koic
Copy link
Member

koic commented Aug 19, 2020

Thanks!

@tejasbubane tejasbubane deleted the fix-8518 branch August 19, 2020 12:31
Drenmi pushed a commit to Drenmi/rubocop that referenced this pull request Aug 20, 2020
[Fix rubocop#8518] Fix `Lint/ConstantResolution` cop reporting offense for `module` and `class` definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/ConstantResolution: Fully qualify a module name?
3 participants