Merge pull request #8542 from tejasbubane/fix-8518

[Fix #8518] Fix `Lint/ConstantResolution` cop reporting offense for `module` and `class` definitions

CHANGELOG.md

@@ -18,6 +18,7 @@
 * [#8507](https://github.com/rubocop-hq/rubocop/issues/8507): Fix `Style/RescueModifier` to handle parentheses around rescue modifiers. ([@dsavochkin][])
 * [#8527](https://github.com/rubocop-hq/rubocop/pull/8527): Prevent an incorrect auto-correction for `Style/CaseEquality` cop when comparing with `===` against a regular expression receiver. ([@koic][])
 * [#8524](https://github.com/rubocop-hq/rubocop/issues/8524): Fix `Layout/EmptyLinesAroundClassBody`  and `Layout/EmptyLinesAroundModuleBody` to correctly handle an access modifier as a first child. ([@dsavochkin][])
+* [#8518](https://github.com/rubocop-hq/rubocop/issues/8518): Fix `Lint/ConstantResolution` cop reporting offense for `module` and `class` definitions. ([@tejasbubane][])
 
 ### Changes
 

lib/rubocop/cop/lint/constant_resolution.rb

@@ -63,7 +63,7 @@ class ConstantResolution < Base
         PATTERN
 
         def on_const(node)
-          return unless unqualified_const?(node)
+          return if !unqualified_const?(node) || node.parent&.defined_module
 
           add_offense(node)
         end

spec/rubocop/cop/lint/constant_resolution_spec.rb

@@ -27,6 +27,15 @@
     RUBY
   end
 
+  context 'module & class definitions' do
+    it 'does not register offense' do
+      expect_no_offenses(<<~RUBY)
+        module Foo; end
+        class Bar; end
+      RUBY
+    end
+  end
+
   context 'with Only set' do
     let(:cop_config) { { 'Only' => ['MY_CONST'] } }