[Fix #8466] Fix a false positive for Lint/UriRegexp
#8467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#8466. This PR fixes a false positive for `Lint/UriRegexp` when using `regexp` method without receiver.
|
@koic uses of https://ruby-doc.org/core-2.7.0/MatchData.html#method-i-regexp |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Aug 6, 2020
koic
added a commit
to koic/rubocop
that referenced
this pull request
Aug 6, 2020
Follow rubocop#8467 (comment). This PR fixes false positive for `Lint/UriRegexp` when using `regexp` with variable receiver.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Aug 7, 2020
Follow #8467 (comment). This PR fixes false positive for `Lint/UriRegexp` when using `regexp` with variable receiver.
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Aug 11, 2020
Remove unnecessary disable of RuboCop `Lint/UriRegexp` lint in `MatchData#==`. I reported this upstream in rubocop/rubocop#8467 (comment) and the bug was fixed in rubocop/rubocop#8476.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8466.
This PR fixes a false positive for
Lint/UriRegexpwhen usingregexpmethod without receiver.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.