[Fix #8347] Fix an incorrect auto-correct for Style/HashSyntax
#8351
Conversation
Fixes rubocop#8347. This PR fixes an incorrect auto-correct for `EnforcedStyle: hash_rockets` of `Style/HashSyntax` with `Layout/HashAlignment`.
| ) | ||
| RUBY | ||
| end | ||
|
|
There was a problem hiding this comment.
Amazing - I just spent about four hours trying to get this to work via way overcomplicating the expect_correction method (basically by adding a let(:run_first) variable). This is a million times cleaner. :) Going to miss having a PR to Rubocop but I guess I'll have other opportunities!
There was a problem hiding this comment.
I'm curious: what was the difficulty with expect_correction? This test with the CLI is much slower...
There was a problem hiding this comment.
The issue is that you can only run one cop at a time. There's no easy way to pass it multiple cops to run one after another. This bug only happens when one cop makes a change and the next one makes a second change - the two insertions end up in an invalid state.
There was a problem hiding this comment.
I was under the impression that let(:other_cops) { { 'Other/Cop' => ... } } was the way to go, but indeed looks like it's not the case. I opened #8352 as it should be easily doable to specify additional cops.
|
Thanks! |
Fixes #8347.
This PR fixes an incorrect auto-correct for
EnforcedStyle: hash_rocketsofStyle/HashSyntaxwithLayout/HashAlignment.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.