Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared_context should allow for multiple cops #8352

Closed
marcandre opened this issue Jul 16, 2020 · 3 comments
Closed

shared_context should allow for multiple cops #8352

marcandre opened this issue Jul 16, 2020 · 3 comments
Assignees
@marcandre
Labels
maintenance

Comments

@marcandre
Copy link
Contributor

There's no easy way to test interactions between multiple cops' autocorrections currently.
@marcandre marcandre self-assigned this Jul 16, 2020
@marcandre marcandre mentioned this issue Jul 16, 2020
Merged
8 tasks
@dorner
Copy link

dorner commented Jul 16, 2020

I can push my PR for #8351 and repurpose it for this instead, since I got it working there.

dorner pushed a commit to wishabi/rubocop that referenced this issue Jul 16, 2020
[Fixes rubocop#8352] Allow multiple cops in shared_context.
168d43d 
This allows additional cops to be run before the current one, allowing us to test interactions between cops more effectively.
@dorner dorner mentioned this issue Jul 16, 2020
Closed
8 tasks
dorner pushed a commit to wishabi/rubocop that referenced this issue Jul 16, 2020
rubocop#8352: Move merged_correctors to InvestigationReport
8766aad
dorner pushed a commit to wishabi/rubocop that referenced this issue Jul 16, 2020
rubocop#8352: Code review fixes
3e63f43
dorner pushed a commit to wishabi/rubocop that referenced this issue Jul 16, 2020
rubocop#8352: Forgot to compact!
7f03f5f
@marcandre
Copy link
Contributor Author

Not as clearly needed as I thought. Closing for now.

@marcandre
Copy link
Contributor Author

Also: I can't recall when I tweaked how the correctors are merged, but it might be more difficult to create issues that need to happen at the same time. Should be ever more true whenever I manage to tweak the TreeRewriter to improve conflicts detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcandre marcandre

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fixes #8352] Allow multiple cops in shared_context. wishabi/rubocop
3 participants
@marcandre @bbatsov @dorner