Tweaks to Metrics/PerceivedComplexity #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
perceptioniseverything
branch
from
429f917
to
53cb861
Compare
koic
reviewed
Jun 24, 2020
marcandre
force-pushed
the
perceptioniseverything
branch
from
53cb861
to
71119ff
Compare
|
@jonas054 what do you think of this? |
jonas054
approved these changes
Jul 9, 2020
|
@marcandre Go ahead and merge this at your discretion. |
marcandre
force-pushed
the
perceptioniseverything
branch
from
71119ff
to
3fe1341
Compare
marcandre
force-pushed
the
perceptioniseverything
branch
from
3fe1341
to
e7ec360
Compare
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Jul 30, 2020
Follow rubocop/rubocop#8204. This commit suppresses the following RuboCop's offense. ```console % bundle exec rubocop (snip) Offenses: lib/rubocop/cop/rails/save_bang.rb:141:57: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of Metrics/PerceivedComplexity. # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 181 files inspected, 1 offense detected RuboCop failed! ```
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics/PerceivedComplexitycurrently ignoreselsebranches incasestatement which seems like a clear bug, considering the weight if gives toelsein if statements:For the rest, there's no clear definition of what
PerceivedComplexityis supposed to do, but it sounds like it's the same thing asCyclomaticComplexitywith a twist forcaseandifwithelse.This PR fixes the
elseissue and makes the same changes that #8149 made for CyclomaticComplexity (||=, iterating methods, etc.) Default bumped also from 7 to 8. 3 new todos all of which are already CyclomaticComplexity todos.If we're ok with these fixes, it would be best for v1 as it is breaking.