Remove save_screenshot from Lint/Debugger
#7853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Capybara::Session#save_screenshot` isn't an entry point; it writes a file noninteractively and is suitable for use in CI. Overview: | Method | Interactive | Reported | | -------------------------- | ----------- | -------- | | `save_page` | No | No | | `save_screenshot` | No | Yes → No | | `save_and_open_page` | Yes | Yes | | `save_and_open_screenshot` | Yes | Yes |
AndrewKvalheim
added a commit
to AndrewKvalheim/osem
that referenced
this pull request
Apr 5, 2020
|
Good points. I think we should probably also extend the cops documentation to make its purpose clearer. I also really dislike that we hardcoded the things we check for instead of providing them to the cop via configuration. |
|
I strongly hope that this PR will be merged. 🙏 🙏 🙏 |
|
@ybiquitous It seems @AndrewKvalheim has lost interest in it, so I can suggest for you to pick it up if you're interested in driving it to the finish line. |
|
@bbatsov Thanks, with pleasure! I'll open a new PR later. 💪 |
8 tasks
|
I've opened PR #8920! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
Lint/Debuggeracross possible debugging methods is inconsistent:putssave_pagesave_screenshotprysave_and_open_pagesave_and_open_screenshotCapybara's
save_screenshotprobably shouldn't be reported, as it just writes a file noninteractively.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.