Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AllowedMethods option to Lint/Debugger cop #8927

Closed
ybiquitous opened this issue Oct 23, 2020 · 0 comments · Fixed by #8929
Closed

Add AllowedMethods option to Lint/Debugger cop #8927

ybiquitous opened this issue Oct 23, 2020 · 0 comments · Fixed by #8929
Labels
enhancement good first issue Easy task, suitable for newcomers to the project

Comments

@ybiquitous
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The methods that Lint/Debugger cop supports are hard-coded now.

https://github.com/rubocop-hq/rubocop/blob/c0ba0398bee24be84cead06f9a55792557d91f5f/lib/rubocop/cop/lint/debugger.rb#L38-L41

This is not useful because users cannot configure methods they want.

Describe the solution you'd like

Like Lint/RedundantSafeNavigation cop, I suggest AllowedMethods option to Lint/Debugger cop.

https://github.com/rubocop-hq/rubocop/blob/25c22bc3efed74092d26cadef75447f646cbbf2d/config/default.yml#L1762-L1773

Describe alternatives you've considered

I don't have alternatives.

Additional context

See the comments below:
@ybiquitous ybiquitous mentioned this issue Oct 23, 2020
Merged
8 tasks
@bbatsov bbatsov added enhancement good first issue Easy task, suitable for newcomers to the project labels Oct 23, 2020
@mfbmina mfbmina mentioned this issue Oct 23, 2020
Merged
8 tasks
mfbmina added a commit to mfbmina/rubocop that referenced this issue Nov 5, 2020
@mfbmina
Fix rubocop#8927 - Add allowed method for Lint/Debugger
6dfdf86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy task, suitable for newcomers to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add allowed method for Lint/Debugger mfbmina/rubocop
2 participants
@bbatsov @ybiquitous