Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6778] Fix a false positive in Style/HashSyntax cop #6948

Merged
merged 1 commit into from Apr 19, 2019

Conversation

tatsuyafw
Copy link
Contributor

Fixes #6778

The Style/HashSyntax cop would register an offense when EnforcedStyle was ruby19_no_mixed_keys and a hash key was an interpolated string like the following code:

{"#{foo}": 1}

This change fixes that.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

The `Style/HashSyntax` cop would register an offense when `EnforcedStyle` was
`ruby19_no_mixed_keys` and a hash key was an interpolated string
like the following code:

```
{"#{foo}": 1}
```

This change fixes that.
@bbatsov bbatsov merged commit fc5acde into rubocop:master Apr 19, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 19, 2019

Thanks!

@tatsuyafw tatsuyafw deleted the bugfix/hash-syntax-cop branch April 19, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/HashSyntax reports errors with string interpolated Symbol names
2 participants