Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodePattern: Optimize by using placeholders for post processing #6909

Merged
merged 2 commits into from Apr 10, 2019
Merged

NodePattern: Optimize by using placeholders for post processing #6909

merged 2 commits into from Apr 10, 2019

Commits on Apr 9, 2019

  1. Simplify code by using attribute instead of argument

    @marcandre
    marcandre committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    f95803a View commit details
    Browse the repository at this point in the history

  2. NodePattern: Optimize by using placeholders for post processing 

    This as multiple benefits:
- allows more flexible handling of future multiple match patterns.
  Handling of '...' was already using a less flexible post-processing.
- deals automatically and better with generated temporary variables
- much less argument passing to the various compiling methods
- factorizes the `#{'.type' if seq_head}` pattern that was everywhere.
- makes debugging easier with simpler & nicer generated code
    @marcandre
    marcandre committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    c89a32c View commit details
    Browse the repository at this point in the history