NodePattern: Optimize by using placeholders for post processing #6909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improved handling of
...
had to use some post-processing of thecur_node
(#6843)The easiest way to provide other "multiple match" patterns (e.g. #6841) would involve similar post-processing. This PR paves the way by using post processing of the current node pattern everywhere.
This as other multiple benefits:
#{'.type' if seq_head}
pattern that was everywhere.I had hoped to be able to minimize the number of node guards, but unions make it tricky.
For the record, here's an example of the code generated before & after.