Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12703] Fix an error for Lint/MixedCaseRange with invalid byte sequence in UTF-8 #12751

Merged
merged 1 commit into from Mar 7, 2024

Conversation

Earlopain
Copy link
Contributor

Closes #12703

While this fixes the above issues, there is still a problem with this cop. If a regex contains this escape and also contains an offense, it will still error. I have openend #12750 for this. Fixing this as well turned out to be too complicated for me.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 3118f00 into rubocop:master Mar 7, 2024
33 checks passed
@koic
Copy link
Member

koic commented Mar 7, 2024

Thanks!

@Earlopain Earlopain deleted the fix-12703 branch March 11, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid byte sequence in UTF-8 error while linting regexp with Lint/MixedCaseRange cop
2 participants