Merge pull request #12751 from Earlopain/fix-12703

[Fix #12703] Fix an error for `Lint/MixedCaseRange` with invalid byte sequence in UTF-8
rubocop · Mar 7, 2024 · 3118f00 · 3118f00
2 parents af3bdeb + b3d3bb5
commit 3118f00
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_error_for_lint_mixed_case_range.md b/changelog/fix_error_for_lint_mixed_case_range.md
@@ -0,0 +1 @@
+* [#12703](https://github.com/rubocop/rubocop/issues/12703): Fix an error for `Lint/MixedCaseRange` with invalid byte sequence in UTF-8. ([@earlopain][])
diff --git a/lib/rubocop/cop/utils/regexp_ranges.rb b/lib/rubocop/cop/utils/regexp_ranges.rb
@@ -88,7 +88,7 @@ def compose_range(expressions, current)
         end
 
         def escaped_octal?(expr)
-          expr.text =~ /^\\[0-7]$/
+          expr.text.valid_encoding? && expr.text =~ /^\\[0-7]$/
         end
 
         def octal_digit?(char)

diff --git a/spec/rubocop/cop/lint/mixed_case_range_spec.rb b/spec/rubocop/cop/lint/mixed_case_range_spec.rb
@@ -227,4 +227,10 @@
       foo = /[a-[bc]]/
     RUBY
   end
+
+  it 'does not register an offense with invalid byte sequence in UTF-8' do
+    expect_no_offenses(<<~'RUBY')
+      foo = /[\–]/
+    RUBY
+  end
 end