Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundler from the default AllowedGems of Gemspec/DevelopmentDependencies #11539

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 5, 2023

Follow up #11469 (comment).

This PR removes bundler from default AllowedGems of Gemspec/DevelopmentDependencies It is a oversight of RuboCop development and should not be configured globally in config/default.yml.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ntDependencies`

Follow up rubocop#11469 (comment).

This PR removes `bundler` from default `AllowedGems` of `Gemspec/DevelopmentDependencies`
It is a oversight of RuboCop development and should not be configured globally in config/default.yml.
@bbatsov bbatsov merged commit a734a02 into rubocop:master Feb 5, 2023
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 5, 2023

Thanks!

@koic koic deleted the remove_bundler_from_default_allowed_gems branch February 5, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants