Skip to content

Commit

Permalink
Remove bundler from the default AllowedGems of `Gemspec/Developme…
Browse files Browse the repository at this point in the history
…ntDependencies`

Follow up #11469 (comment).

This PR removes `bundler` from default `AllowedGems` of `Gemspec/DevelopmentDependencies`
It is a oversight of RuboCop development and should not be configured globally in config/default.yml.
  • Loading branch information
koic authored and bbatsov committed Feb 5, 2023
1 parent 596ed4e commit a734a02
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ gemspec

gem 'asciidoctor'
gem 'bump', require: false
gem 'bundler', '>= 1.15.0', '< 3.0'
gem 'memory_profiler', platform: :mri
gem 'rake', '~> 13.0'
gem 'rspec', '~> 3.7'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#11539](https://github.com/rubocop/rubocop/pull/11539): Remove `bundler` from default `AllowedGems` of `Gemspec/DevelopmentDependencies`. ([@koic][])
3 changes: 1 addition & 2 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,7 @@ Gemspec/DevelopmentDependencies:
- Gemfile
- gems.rb
- gemspec
AllowedGems:
- bundler
AllowedGems: []
Include:
- '**/*.gemspec'
- '**/Gemfile'
Expand Down
2 changes: 0 additions & 2 deletions rubocop.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,4 @@ Gem::Specification.new do |s|
s.add_runtime_dependency('rubocop-ast', '>= 1.24.1', '< 2.0')
s.add_runtime_dependency('ruby-progressbar', '~> 1.7')
s.add_runtime_dependency('unicode-display_width', '>= 2.4.0', '< 3.0')

s.add_development_dependency('bundler', '>= 1.15.0', '< 3.0')
end

0 comments on commit a734a02

Please sign in to comment.