Fix disabling departments via comment #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
fix-disabling-departments
branch
from
8670255
to
d1660e5
Compare
That's weird, but I'll take your word for it. |
|
Yeah, it's weird that the tests don't reproduce, but I also confirmed the fixed behavior locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11308.
This is a solution as in a similar from this cop -
rubocop/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb
Line 127 in 8bb0c47
I was not able to reproduce it on an existing app, only on a sample new app (as mentioned in the issue description).
Was not able to create a failing test script for this too.