Fix disabling departments via comment

rubocop · Dec 21, 2022 · d1660e5 · d1660e5
1 parent 8bb0c47
commit d1660e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog/fix_disabling_departments_via_comment.md b/changelog/fix_disabling_departments_via_comment.md
@@ -0,0 +1 @@
+* [#11308](https://github.com/rubocop/rubocop/issues/11308): Fix disabling departments via comment. ([@fatkodima][])
diff --git a/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb b/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb
@@ -128,6 +128,7 @@ def each_line_range(cop, line_ranges)
           end
         end
 
+        # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def each_already_disabled(cop, line_ranges)
           line_ranges.each_cons(2) do |previous_range, range|
             next if ignore_offense?(range)
@@ -152,9 +153,10 @@ def each_already_disabled(cop, line_ranges)
                 cop
               end
 
-            yield comment, redundant
+            yield comment, redundant if redundant
           end
         end
+        # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
         def find_redundant_cop(cop, range)
           cop_offenses = offenses_to_check.select { |offense| offense.cop_name == cop }