Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation change #10718

Closed
wants to merge 1 commit into from
Closed

Conversation

bquorning
Copy link
Contributor

@bquorning bquorning commented Jun 16, 2022

It looks like we forgot to run rake update_cops_documentation in the pull request #10697. I don't know how CI didn't catch this.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

It looks like we forgot to run `rake update_cops_documentation` in the
pull request #10697. I don't know how CI didn't catch this.
@bquorning bquorning requested a review from koic June 16, 2022 17:34
@bquorning bquorning marked this pull request as ready for review June 16, 2022 17:34
@koic
Copy link
Member

koic commented Jun 16, 2022

These are not needed as they are auto-generated at release time.

@koic
Copy link
Member

koic commented Jun 16, 2022

See #9045 for more information.

  • processing code moved to new task update_cops_documentation (no public description) that is triggered by cut_release

@bquorning
Copy link
Contributor Author

Thanks. I guess it’s been a while since I really worked in this repo last.

@bquorning bquorning closed this Jun 17, 2022
@bquorning bquorning deleted the update-cops-documentation branch June 17, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants