[Fix #10258] Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4
#10632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
analyze_ruby_24_code
branch
from
b52c6b7
to
d2325f9
Compare
…ersion: 2.4` Fixes rubocop#10258 and reverts part of rubocop#9648. Only the Ruby version (2.4) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.4 code analysis with `TargetRubyVersion: 2.4`. So, this keeps it compatible with `TargetRubyVersion` up to RuboCop 1.12.1 as semver. It aims to solve essentially the same problem as rubocop#10626.
koic
force-pushed
the
analyze_ruby_24_code
branch
from
d2325f9
to
972a4a7
Compare
koic
changed the title
TargetRubyVersion: 2.4TargetRubyVersion: 2.4
|
Thanks! |
|
I'm thinking we should also update the compatibility docs to mention separately the runtime support and the analysis support for the various releases. |
|
Yeah. OTOH, I will try to recover as much as possible to analysis the old Ruby versions code. |
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
May 13, 2022
RuboCop can analyze Ruby 1.9 or later. But now it turns out that RuboCop hasn't been able to parse older Ruby versions. https://docs.rubocop.org/rubocop/1.29/compatibility.html#support-matrix Analysis Ruby code and runtime Ruby versions are different. So, only runtime version should have been dropped. This PR makes it possible to parse older Ruby versions that were accidentally dropped before RuboCop AST was separated from RuboCop core. With this fix, the following recovery work will be possible. - Recover for Ruby 2.5 analysis: rubocop/rubocop#10626 - Recover for Ruby 2.4 analysis: rubocop/rubocop#10632
marcandre
pushed a commit
to rubocop/rubocop-ast
that referenced
this pull request
May 13, 2022
RuboCop can analyze Ruby 1.9 or later. But now it turns out that RuboCop hasn't been able to parse older Ruby versions. https://docs.rubocop.org/rubocop/1.29/compatibility.html#support-matrix Analysis Ruby code and runtime Ruby versions are different. So, only runtime version should have been dropped. This PR makes it possible to parse older Ruby versions that were accidentally dropped before RuboCop AST was separated from RuboCop core. With this fix, the following recovery work will be possible. - Recover for Ruby 2.5 analysis: rubocop/rubocop#10626 - Recover for Ruby 2.4 analysis: rubocop/rubocop#10632
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
May 15, 2022
8 tasks
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
May 15, 2022
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 16, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#7869 and rubocop#8056. Only the Ruby version (2.3) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.3 code analysis with `TargetRubyVersion: 2.3`. It aims to solve essentially the same problem as rubocop#10626 and 10632. And this change requires RuboCop AST 1.18 or later: rubocop/rubocop-ast#233
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 18, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#6766, rubocop#7026, and rubocop#7030. Only the Ruby version (2.2) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.2 code analysis with `TargetRubyVersion: 2.2`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, and rubocop#10640. Previously, there was the following default enforced style `when_needed` for `Style/FrozenStringLiteralComment` cop. ```ruby # @example EnforcedStyle: when_needed (default) # # The `when_needed` style will add the frozen string literal # # to files only when the `TargetRubyVersion` is set to 2.3+. # # bad # module Foo # # ... # end # # # good # # frozen_string_literal: true # # module Foo # # ... # end ``` This PR does not restore that option, but sets the `minimum_target_ruby_version 2.3` to make `always (default)` apply by default. It is a simple solution that does not handle frozen literal magic comment added in Ruby 2.3 when `TargetRubyVersion` is Ruby 2.2 or lower.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 23, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#5990 and rubocop#6101. Only the Ruby version (2.1) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.1 code analysis with `TargetRubyVersion: 2.1`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, rubocop#10640, and rubocop#10644.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 25, 2022
Follow up rubocop#10632 (comment). Reverts part of rubocop#4787. Only the Ruby version (2.0) to runtime should have been dropped, not code analysis. This PR makes Ruby 2.0 code analysis with `TargetRubyVersion: 2.0`. It aims to solve essentially the same problem as rubocop#10626, rubocop#10632, rubocop#10640, rubocop#10644, and rubocop#10662.
|
Has runtime analysis always been decoupled from I'm curious because I work against Ruby that is embedded in an desktop application, meaning I have to support a wide range of Ruby versions on the same code-base. I've these RuboCop configs: Having runtime support decoupled from static analysis support is a big double thumbs up from me! 👍👍 |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 30, 2022
Follow up rubocop#10632 (comment). RuboCop targets Ruby 2.0+ code analysis since RuboCop 1.30. This PR tweaks docs about target Ruby version. NOTE: Ruby 1.9 code analysis is not restored because its some incompatibilities with Ruby 2.0+ cops. It may not be worth the maintenance cost.
bbatsov
pushed a commit
that referenced
this pull request
May 30, 2022
Follow up #10632 (comment). RuboCop targets Ruby 2.0+ code analysis since RuboCop 1.30. This PR tweaks docs about target Ruby version. NOTE: Ruby 1.9 code analysis is not restored because its some incompatibilities with Ruby 2.0+ cops. It may not be worth the maintenance cost.
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
Follow up rubocop/rubocop#10632. Reverts #232 and rubocop/rubocop-performance@e3c374b.
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
Follow up rubocop/rubocop#10632. Reverts #232 and rubocop/rubocop-performance@e3c374b.
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
Follow up rubocop/rubocop#10632. Reverts #232 and rubocop/rubocop-performance@e3c374b.
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Follow up rubocop/rubocop#10632. Reverts #232 and rubocop/rubocop-performance@e3c374b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10258 and reverts part of #9648.
Only the Ruby version (2.4) to runtime should have been dropped, not code analysis.
This PR makes Ruby 2.4 code analysis with
TargetRubyVersion: 2.4.So, this keeps it compatible with
TargetRubyVersionup to RuboCop 1.12.1 as semver.It aims to solve essentially the same problem as #10626.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.