Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4
#288
Conversation
koic
force-pushed
the
recover_ruby_24_analysis
branch
from
ddbdd1a
to
c7ba54e
Compare
|
Hello again @koic! I saw that in the main repository you restored analysis support all the way back to Ruby 2.0, and here you restored Ruby 2.4 code analysis, are you planning to restore 2.3 code analysis here? Thanks so much! |
|
@deivid-rodriguez Restoring is done up to Ruby 2.0, but I may have overlooked cops. Are there any cops found to have problems in Ruby 2.3 and lower code analysis? |
|
Nope, I didn't find any issues so far. My "problem" is that in RubyGems & Bundler, we still support all the way down to Ruby 2.3. So uncoupling the runtime from the target code is beneficial to us, because it allows us to upgrade RuboCop without having to drop support for Ruby 2.3 (we were locked at RuboCop 0.80.1 until now). If the same change is made to |
|
Ah, I understand! The latest RuboCop Performance is expected to be able to analyze from Ruby 2.0 to Ruby 3.1 code. |
|
Oh, sorry, I recall now. I did get un-expected issues, I recall now. I got offenses about |
Follow up rubocop#288 (comment). This PR fixes a false positive for `Performance/RegexpMatch` when `TargetRubyVersion: 2.3`.
|
I've opened #292 to resolve the false positive. I will be released soon. Please wait a moment. |
|
Thank you! |
|
@deivid-rodriguez RuboCop Performance 1.14.2 has been released. Thank you too! |
Follow up rubocop/rubocop-performance#288 (comment). This PR fixes a false positive for `Performance/RegexpMatch` when `TargetRubyVersion: 2.3`.
Follow up rubocop/rubocop-performance#288 (comment). This PR fixes a false positive for `Performance/RegexpMatch` when `TargetRubyVersion: 2.3`.
Follow up rubocop/rubocop-performance#288 (comment). This PR fixes a false positive for `Performance/RegexpMatch` when `TargetRubyVersion: 2.3`.
Follow up rubocop/rubocop-performance#288 (comment). This PR fixes a false positive for `Performance/RegexpMatch` when `TargetRubyVersion: 2.3`.
Follow up rubocop/rubocop#10632.
Reverts #232 and e3c374b.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.