[Fix #10230] Fix a false positive for Lint/AmbiguousRange

changelog/fix_a_false_positive_for_lint_ambiguous_range.md

@@ -0,0 +1 @@
+* [#10230](https://github.com/rubocop/rubocop/issues/10230): Fix a false positive for `Lint/AmbiguousRange` when a range is composed of all literals except basic literals. ([@koic][])

lib/rubocop/cop/lint/ambiguous_range.rb

@@ -8,7 +8,7 @@ module Lint
       # Ranges have quite low precedence, which leads to unexpected behaviour when
       # using a range with other operators. This cop avoids that by making ranges
       # explicit by requiring parenthesis around complex range boundaries (anything
-      # that is not a basic literal: numerics, strings, symbols, etc.).
+      # that is not a literal: numerics, strings, symbols, etc.).
       #
       # This cop can be configured with `RequireParenthesesForMethodChains` in order to
       # specify whether method chains (including `self.foo`) should be wrapped in parens
@@ -81,7 +81,7 @@ def each_boundary(range)
 
         def acceptable?(node)
           node.begin_type? ||
-            node.basic_literal? ||
+            node.literal? ||
             node.variable? || node.const_type? || node.self_type? ||
             (node.call_type? && acceptable_call?(node))
         end

spec/rubocop/cop/lint/ambiguous_range_spec.rb

@@ -55,10 +55,15 @@
         RUBY
       end
 
-      it 'does not register an offense if the range is composed of basic literals' do
+      it 'does not register an offense if the range is composed of literals' do
         expect_no_offenses(<<~RUBY)
           1#{operator}2
           'a'#{operator}'z'
+          "\#{foo}-\#{bar}"#{operator}'123-4567'
+          `date`#{operator}'foobar'
+          :"\#{foo}-\#{bar}"#{operator}:baz
+          /a/#{operator}/b/
+          42#{operator}nil
         RUBY
       end