[Fix #10230] Fix a false positive for Lint/AmbiguousRange
#10232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some literals == different literal types? |
Fixes rubocop#10230. This PR fixes a false positive for `Lint/AmbiguousRange` when a range is composed of all literals except basic literals. If it's just literals, it's clear even without parentheses, so this PR will accept them.
|
I'm sorry for the confusion. Some literals meant all literals except basic literals. So, I think all literals (not only basic literals) will be in a clear (unambiguous) range. |
koic
force-pushed
the
fix_a_false_positive_for_lint_ambiguous_range
branch
from
a9f90f4
to
e2ec786
Compare
|
Got it. Seems to me you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10230.
This PR fixes a false positive for
Lint/AmbiguousRangewhen a range is composed of some literals.If it's just literals, it's clear even without parentheses, so this PR will accept them.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.