Fix Gemspec/RequiredRubyVersion version matcher #10354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpellant
force-pushed
the
fix-required-ruby-version-cop-with-multiple-gem-requirements
branch
from
a615975
to
adaec0e
Compare
Fixes a bug believed to be introduced by rubocop#10157 where the cop no longer supported multiple requirements when they were passed as a `Gem::Requirement` object instead of as an array.
nickpellant
force-pushed
the
fix-required-ruby-version-cop-with-multiple-gem-requirements
branch
from
adaec0e
to
5cf2af2
Compare
|
Looks good. Thanks! |
nickpellant
deleted the
fix-required-ruby-version-cop-with-multiple-gem-requirements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug (which I believe was introduced by #10157) where the
Gemspec/RequiredRubyVersioncop no longer handled multiple requirements when they were passed as aGem::Requirementobject rather than an array.I.e. the following would fail when the target version was
2.6:Which should pass like the following does:
Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.