Style/ExplicitBlockArgument: do not assume the block parameter name #10064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
explicit-block-corrector
branch
from
4afe57b
to
b6ab000
Compare
|
Can you please add a changelog entry? |
casperisfine
force-pushed
the
explicit-block-corrector
branch
from
b6ab000
to
faf6ae0
Compare
|
@dvandersluis done! |
casperisfine
force-pushed
the
explicit-block-corrector
branch
from
faf6ae0
to
d97de7b
Compare
|
Thanks but we actually don't update |
The autocorector would generate invalid code if the old code already defined the block parameter with any other name than `&block`.
casperisfine
force-pushed
the
explicit-block-corrector
branch
from
d97de7b
to
e44b0a8
Compare
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autocorector would generate invalid code if the old code already defined the block parameter with any other name than
&block.