Enable Style/ExplicitBlockArgument cop
#43170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
force-pushed
the
rubocop-explicit-block-argument
branch
3 times, most recently
from
25e35f8
to
d4afdc2
Compare
This reduce the stack size which is beneficial for exceptions performance. See: https://gist.github.com/byroot/cb3bcadcc3701c2518d002fb8d3a4e7a However the cop is unsafe because it might change the block arity, so it can run into some false positives.
byroot
force-pushed
the
rubocop-explicit-block-argument
branch
from
d4afdc2
to
c91c266
Compare
|
So no false positive. The autocorrector however generated a few broken methods, but I fixed them manually no big deal. |
Upstream PR: rubocop/rubocop#10064 |
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Sep 6, 2021
Follow up to rails/rails#43170.
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Sep 6, 2021
Follow up to rails/rails#43170.
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Sep 6, 2021
Follow up to rails/rails#43170.
koic
added a commit
to koic/oracle-enhanced
that referenced
this pull request
Sep 6, 2021
Follow up to rails/rails#43170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduce the stack size which is beneficial for
exceptions performance.
See: https://gist.github.com/byroot/cb3bcadcc3701c2518d002fb8d3a4e7a
However the cop is unsafe because it might change the block arity,
so it can run into some false positives.
But let's see how much false positives it runs into.