Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #9674] Disable Style/AsciiComments by default. #10045

Merged
merged 1 commit into from Aug 26, 2021
Merged

[Fix #9674] Disable Style/AsciiComments by default. #10045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/change_disable_styleasciicomments_by_default.md
View file
Open in desktop
@@ -0,0 +1 @@
* [#9674](https://github.com/rubocop/rubocop/issues/9674): Disable `Style/AsciiComments` by default. ([@dvandersluis][])
4 changes: 2 additions & 2 deletions config/default.yml
View file
Open in desktop
Expand Up @@ -2831,9 +2831,9 @@ Style/ArrayJoin:
Style/AsciiComments:
Description: 'Use only ascii symbols in comments.'
StyleGuide: '#english-comments'
Enabled: true
Enabled: false
VersionAdded: '0.9'
VersionChanged: '0.52'
VersionChanged: '<<next>>'
AllowedChars:
- ©

Expand Down
3 changes: 0 additions & 3 deletions lib/rubocop/cop/naming/ascii_identifiers.rb
View file
Open in desktop
@@ -1,7 +1,5 @@
# frozen_string_literal: true

# rubocop:disable Style/AsciiComments

module RuboCop
module Cop
module Naming
Expand Down Expand Up @@ -90,4 +88,3 @@ def first_non_ascii_chars(string)
end
end
end
# rubocop:enable Style/AsciiComments
3 changes: 0 additions & 3 deletions lib/rubocop/cop/style/ascii_comments.rb
View file
Open in desktop
@@ -1,7 +1,5 @@
# frozen_string_literal: true

# rubocop:disable Style/AsciiComments

module RuboCop
module Cop
module Style
Expand Down Expand Up @@ -57,4 +55,3 @@ def allowed_non_ascii_chars
end
end
end
# rubocop:enable Style/AsciiComments
17 changes: 3 additions & 14 deletions spec/fixtures/html_formatter/expected.html
View file
Open in desktop
Expand Up @@ -367,14 +367,14 @@ <h1 class="title">RuboCop Inspection Report</h1>
<div class="infobox">
<div class="total">
3 files inspected,
23 offenses detected:
22 offenses detected:
</div>
<ul class="offenses-list">


<li>
<a href="#offense_app/controllers/application_controller.rb">
app/controllers/application_controller.rb - 2 offenses
app/controllers/application_controller.rb - 1 offense
</a>
</li>

Expand All @@ -400,7 +400,7 @@ <h1 class="title">RuboCop Inspection Report</h1>

<div class="offense-box" id="offense_app/controllers/application_controller.rb">
<div class="box-title-placeholder"><h3>&nbsp;</h3></div>
<div class="box-title"><h3>app/controllers/application_controller.rb - 2 offenses</h3></div>
<div class="box-title"><h3>app/controllers/application_controller.rb - 1 offense</h3></div>
<div class="offense-reports">

<div class="report">
Expand All @@ -414,17 +414,6 @@ <h1 class="title">RuboCop Inspection Report</h1>

</div>

<div class="report">
<div class="meta">
<span class="location">Line #6</span> –
<span class="severity convention">convention:</span>
<span class="message">Style/AsciiComments: Use only ascii symbols in comments.</span>
</div>

<pre><code> # <span class="highlight convention">“</span>Test encoding issues by using curly quotes”</code></pre>

</div>

</div>
</div>

Expand Down