Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9674] Disable Style/AsciiComments by default. #10045

Merged
merged 1 commit into from Aug 26, 2021

Conversation

dvandersluis
Copy link
Member

Style/AsciiComments was decided to be disabled by default, because it is too restrictive. Fixes #9674.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis force-pushed the issue/9674 branch 2 times, most recently from 94d8687 to 199029c Compare August 26, 2021 18:57
@dvandersluis dvandersluis merged commit 1365cb6 into rubocop:master Aug 26, 2021
@dvandersluis dvandersluis deleted the issue/9674 branch September 14, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/AsciiComments default Enabled is true
1 participant