Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RuboCop Performance to 1.10 #9550

Merged
merged 1 commit into from Feb 28, 2021

Conversation

koic
Copy link
Member

@koic koic commented Feb 28, 2021

This PR bumps RuboCop Performance to 1.10 and suppresses the new Performance/RedundantSplitRegexpArgument cop's offenses.

% bundle exec rubocop
(snip)

Offenses:

lib/rubocop/cop/mixin/preferred_delimiters.rb:18:42: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
        preferred_delimiters[type].split(//)
                                         ^^
lib/rubocop/cop/mixin/preferred_delimiters.rb:18:42: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
        preferred_delimiters[type].split("")
                                         ^^
lib/rubocop/cop/style/command_literal.rb:168:58: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
          (command_delimiter || default_delimiter).split(//)
                                                         ^^
lib/rubocop/cop/style/command_literal.rb:168:58: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
          (command_delimiter || default_delimiter).split("")
                                                         ^^
lib/rubocop/cop/style/regexp_literal.rb:153:49: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
            ['PreferredDelimiters']['%r'].split(//)
                                                ^^
lib/rubocop/cop/style/regexp_literal.rb:153:49: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
            ['PreferredDelimiters']['%r'].split("")
                                                ^^
spec/support/alignment_examples.rb:11:26: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
  annotated_source.split(/\n\n/).each do |chunk|
                         ^^^^^^

1265 files inspected, 7 offenses detected, 7 offenses corrected

Before submitting the PR make sure the following are checked:

  • [x ] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR bumps RuboCop Performance to 1.10 and suppresses the new
`Performance/RedundantSplitRegexpArgument` cop's offenses.

```console
% bundle exec rubocop
(snip)

Offenses:

lib/rubocop/cop/mixin/preferred_delimiters.rb:18:42: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
        preferred_delimiters[type].split(//)
                                         ^^
lib/rubocop/cop/mixin/preferred_delimiters.rb:18:42: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
        preferred_delimiters[type].split("")
                                         ^^
lib/rubocop/cop/style/command_literal.rb:168:58: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
          (command_delimiter || default_delimiter).split(//)
                                                         ^^
lib/rubocop/cop/style/command_literal.rb:168:58: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
          (command_delimiter || default_delimiter).split("")
                                                         ^^
lib/rubocop/cop/style/regexp_literal.rb:153:49: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
            ['PreferredDelimiters']['%r'].split(//)
                                                ^^
lib/rubocop/cop/style/regexp_literal.rb:153:49: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
            ['PreferredDelimiters']['%r'].split("")
                                                ^^
spec/support/alignment_examples.rb:11:26: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
  annotated_source.split(/\n\n/).each do |chunk|
                         ^^^^^^

1265 files inspected, 7 offenses detected, 7 offenses corrected
```
@koic koic merged commit 28a8145 into rubocop:master Feb 28, 2021
@koic koic deleted the bump_rubocop_performance_to_1_10 branch February 28, 2021 17:57
This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant