Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump RuboCop Performance to 1.10 #9550

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Bump RuboCop Performance to 1.10 #9550

merged 1 commit into from
Feb 28, 2021

Commits on Feb 28, 2021

  1. Bump RuboCop Performance to 1.10 

    This PR bumps RuboCop Performance to 1.10 and suppresses the new
`Performance/RedundantSplitRegexpArgument` cop's offenses.

```console
% bundle exec rubocop
(snip)

Offenses:

lib/rubocop/cop/mixin/preferred_delimiters.rb:18:42: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
        preferred_delimiters[type].split(//)
                                         ^^
lib/rubocop/cop/mixin/preferred_delimiters.rb:18:42: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
        preferred_delimiters[type].split("")
                                         ^^
lib/rubocop/cop/style/command_literal.rb:168:58: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
          (command_delimiter || default_delimiter).split(//)
                                                         ^^
lib/rubocop/cop/style/command_literal.rb:168:58: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
          (command_delimiter || default_delimiter).split("")
                                                         ^^
lib/rubocop/cop/style/regexp_literal.rb:153:49: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
            ['PreferredDelimiters']['%r'].split(//)
                                                ^^
lib/rubocop/cop/style/regexp_literal.rb:153:49: C: [Corrected]
Style/StringLiterals: Prefer single-quoted strings when you don't need
string interpolation or special symbols.
            ['PreferredDelimiters']['%r'].split("")
                                                ^^
spec/support/alignment_examples.rb:11:26: C: [Corrected]
Performance/RedundantSplitRegexpArgument: Use string as argument instead
of regexp.
  annotated_source.split(/\n\n/).each do |chunk|
                         ^^^^^^

1265 files inspected, 7 offenses detected, 7 offenses corrected
```
    @koic
    koic committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    3790bb7 View commit details
    Browse the repository at this point in the history