Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.10.0 to 1.11.0 in /gemfiles/rails-edge #264

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 8, 2021

Bumps rubocop from 1.10.0 to 1.11.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.11

New features

Bug fixes

  • #9520: Fix an incorrect auto-correct for Style/MultipleComparison when comparing a variable with multiple items in if and elsif conditions. (@​koic)
  • #9548: Fix a false positive for Style/TrailingBodyOnMethodDefinition when endless method definition body is after newline in opening parenthesis. (@​koic)
  • #9541: Fix Style/HashConversion when the correction needs to be wrapped in parens. (@​dvandersluis)
  • #9533: Make metrics length cops aware of multi-line kwargs. (@​koic)
  • #9523: Fix an error for Style/TrailingMethodEndStatement when endless method definition signature and body are on different lines. (@​koic)
  • #9482: Return minimal known ruby version from gemspecs required_ruby_version. (@​HeroProtagonist)
  • #9539: Fix an error for Style/RedundantBegin when using body of begin is empty. (@​koic)
  • #9542: Fix Layout/FirstArgumentIndentation for operator methods not called as operators. (@​dvandersluis, @​TSMMark)

Changes

  • #9526: Add AllowSplatArgument option to Style/HashConversion and the option is true by default. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.11.0 (2021-03-01)

New features

Bug fixes

  • #9520: Fix an incorrect auto-correct for Style/MultipleComparison when comparing a variable with multiple items in if and elsif conditions. ([@​koic][])
  • #9548: Fix a false positive for Style/TrailingBodyOnMethodDefinition when endless method definition body is after newline in opening parenthesis. ([@​koic][])
  • #9541: Fix Style/HashConversion when the correction needs to be wrapped in parens. ([@​dvandersluis][])
  • #9533: Make metrics length cops aware of multi-line kwargs. ([@​koic][])
  • #9523: Fix an error for Style/TrailingMethodEndStatement when endless method definition signature and body are on different lines. ([@​koic][])
  • #9482: Return minimal known ruby version from gemspecs required_ruby_version. ([@​HeroProtagonist][])
  • #9539: Fix an error for Style/RedundantBegin when using body of begin is empty. ([@​koic][])
  • #9542: Fix Layout/FirstArgumentIndentation for operator methods not called as operators. ([@​dvandersluis][], [@​TSMMark][])

Changes

  • #9526: Add AllowSplatArgument option to Style/HashConversion and the option is true by default. ([@​koic][])
Commits
  • 3741eeb Cut 1.11
  • e3287dc Update Changelog
  • 28a8145 Merge pull request #9550 from koic/bump_rubocop_performance_to_1_10
  • 3790bb7 Bump RuboCop Performance to 1.10
  • 2a727f9 [Fix #9533] Fix calc of multiline hash arg length for metrics length cops
  • 8a4ee25 Fix a false positive for Style/TrailingBodyOnMethodDefinition
  • 6fb5d75 Merge pull request #9549 from koic/fix_error_for_internal_affairs_node_matche...
  • aef3d43 Fix an error for InternalAffairs/NodeMatcherDirective
  • 1dd69ab Merge pull request #9506 from dvandersluis/internal/method-directive
  • e850b27 Correct InternalAffairs/NodeMatcherDirective offenses.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 8, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 8, 2021

The following labels could not be found: rails-edge.

@cla-bot
Copy link

cla-bot bot commented Mar 8, 2021

We require contributors to sign our Contributor License Agreement, and we don't have @dependabot[bot] on file. In order for us to review and merge your code, please sign the CLA.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 8, 2021

Looks like rubocop is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Mar 8, 2021
@dependabot dependabot bot deleted the dependabot/bundler/gemfiles/rails-edge/rubocop-1.11.0 branch March 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics/BlockLength (and alike) should be able to ignore multi-line method calls
0 participants