Improve performance with RESTRICT_ON_SEND #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will need to update the following runtime dependency. diff --git a/rubocop-thread_safety.gemspec b/rubocop-thread_safety.gemspec
index 613da28..4606d72 100644
--- a/rubocop-thread_safety.gemspec
+++ b/rubocop-thread_safety.gemspec
@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 2.3.0'
- spec.add_runtime_dependency 'rubocop', '>= 0.53.0'
+ spec.add_runtime_dependency 'rubocop', '>= 0.90.0'
spec.add_development_dependency 'appraisal'
spec.add_development_dependency 'bundler', '>= 1.10', '< 3' |
bquorning
force-pushed
the
restrict-on-send
branch
from
7fc18a1
to
1a29b97
Compare
https://github.com/rubocop/rubocop/blob/master/docs/modules/ROOT/pages/ development.adoc#implementation mentions: > The `on_send` callback is the most used and can be optimized > by restricting the acceptable method names with a constant > `RESTRICT_ON_SEND`.
bquorning
force-pushed
the
restrict-on-send
branch
from
1a29b97
to
aede46c
Compare
|
did all the checks run twice, on push and pull_request? 🤔 |
|
Yes, it looks like they do. Maybe we should copy this part of rubocop-rspec's CI config. |
koic
added a commit
to koic/rubocop-thread_safety
that referenced
this pull request
May 18, 2022
Follow rubocop/rubocop#7868. The legacy `Cop::Cop` API is soft deprecated and this PR use new `Cop::Base` API instead. > maintain any RuboCop extensions, as the legacy API will be removed in RuboCop 2.0. https://metaredux.com/posts/2020/10/21/rubocop-1-0.html This new API requires RuboCop 0.87 or higher. https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06 That dependent version update will be resolved in rubocop#7, so there are no updates in this PR.
koic
added a commit
to koic/rubocop-thread_safety
that referenced
this pull request
May 18, 2022
Follow rubocop/rubocop#7868. The legacy `Cop::Cop` API is soft deprecated and this PR use new `Cop::Base` API instead. > maintain any RuboCop extensions, as the legacy API will be removed in RuboCop 2.0. https://metaredux.com/posts/2020/10/21/rubocop-1-0.html This new API requires RuboCop 0.87 or higher. https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06 That dependent version update will be resolved in rubocop#7, so there are no updates in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rubocop/rubocop/blob/master/docs/modules/ROOT/pages/development.adoc#implementation mentions:
Blocked by #3.