Improve performance with RESTRICT_ON_SEND

https://github.com/rubocop/rubocop/blob/master/docs/modules/ROOT/pages/ development.adoc#implementation mentions: > The `on_send` callback is the most used and can be optimized > by restricting the acceptable method names with a constant > `RESTRICT_ON_SEND`.
rubocop · May 18, 2022 · 1a29b97 · 1a29b97
1 parent e8f99fe
commit 1a29b97
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 35 deletions.
diff --git a/Appraisals b/Appraisals
@@ -1,18 +1,7 @@
 # frozen_string_literal: true
 
-appraise 'rubocop-0.53' do
-  gem 'rubocop', '~> 0.53.0'
-end
-
-appraise 'rubocop-0.81' do
-  gem 'rubocop', '~> 0.81.0'
-end
-
-if Gem::Requirement.new('>= 2.4.0')
-                   .satisfied_by?(Gem::Version.new(RUBY_VERSION))
-  appraise 'rubocop-0.86' do
-    gem 'rubocop', '~> 0.86.0'
-  end
+appraise 'rubocop-0.90' do
+  gem 'rubocop', '~> 0.90.0'
 end
 
 if Gem::Requirement.new('>= 2.5.0')

diff --git a/gemfiles/rubocop_0.81.gemfile b/gemfiles/rubocop_0.81.gemfile
diff --git a/gemfiles/rubocop_0.86.gemfile b/gemfiles/rubocop_0.86.gemfile
diff --git a/gemfiles/rubocop_0.53.gemfile → gemfiles/rubocop_0.90.gemfile b/gemfiles/rubocop_0.53.gemfile → gemfiles/rubocop_0.90.gemfile
@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rubocop", "~> 0.53.0"
+gem "rubocop", "~> 0.90.0"
 
 gemspec path: "../"
diff --git a/lib/rubocop/cop/thread_safety/class_and_module_attributes.rb b/lib/rubocop/cop/thread_safety/class_and_module_attributes.rb
@@ -14,6 +14,12 @@ module ThreadSafety
       #   end
       class ClassAndModuleAttributes < Cop
         MSG = 'Avoid mutating class and module attributes.'
+        RESTRICT_ON_SEND = %i[
+          mattr_writer mattr_accessor cattr_writer cattr_accessor
+          class_attribute
+          attr attr_accessor attr_writer
+          attr_internal attr_internal_accessor attr_internal_writer
+        ].freeze
 
         def_node_matcher :mattr?, <<~MATCHER
           (send nil?

diff --git a/lib/rubocop/cop/thread_safety/instance_variable_in_class_method.rb b/lib/rubocop/cop/thread_safety/instance_variable_in_class_method.rb
@@ -55,6 +55,10 @@ module ThreadSafety
       #   end
       class InstanceVariableInClassMethod < Cop
         MSG = 'Avoid instance variables in class methods.'
+        RESTRICT_ON_SEND = %i[
+          instance_variable_set
+          instance_variable_get
+        ].freeze
 
         def_node_matcher :instance_variable_set_call?, <<~MATCHER
           (send nil? :instance_variable_set (...) (...))

diff --git a/lib/rubocop/cop/thread_safety/new_thread.rb b/lib/rubocop/cop/thread_safety/new_thread.rb
@@ -12,6 +12,7 @@ module ThreadSafety
       #   Thread.new { do_work }
       class NewThread < Cop
         MSG = 'Avoid starting new threads.'
+        RESTRICT_ON_SEND = %i[new].freeze
 
         def_node_matcher :new_thread?, <<~MATCHER
           (send (const {nil? cbase} :Thread) :new)

diff --git a/rubocop-thread_safety.gemspec b/rubocop-thread_safety.gemspec
@@ -26,9 +26,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.3.0'
+  spec.required_ruby_version = '>= 2.4.0'
 
-  spec.add_runtime_dependency 'rubocop', '>= 0.53.0'
+  spec.add_runtime_dependency 'rubocop', '>= 0.90.0'
 
   spec.add_development_dependency 'appraisal'
   spec.add_development_dependency 'bundler', '>= 1.10', '< 3'

diff --git a/spec/rubocop/cop/thread_safety/mutable_class_instance_variable_spec.rb b/spec/rubocop/cop/thread_safety/mutable_class_instance_variable_spec.rb
@@ -4,11 +4,6 @@
                :config do
   subject(:cop) { described_class.new(config) }
   let(:msg) { 'Freeze mutable objects assigned to class instance variables.' }
-  if Gem::Requirement.new('< 0.69')
-                     .satisfied_by?(Gem::Version.new(RuboCop::Version::STRING))
-    let(:ruby_version) { 2.3 }
-  end
-
   let(:prefix) { nil }
   let(:suffix) { nil }
   let(:indent) { '' }