New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix InternalAffairs/NumblockHandler
offenses
#1362
Fix InternalAffairs/NumblockHandler
offenses
#1362
Conversation
Can you briefly explain why the cop in some cases is disabled, and in some cases you can just add an |
2b3cddf
to
f98f442
Compare
For the following cop that I added aliases to, I targeted the ones that take block arguments. All cop that use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Darhazer, would you have a look as well?
f98f442
to
61696b7
Compare
I update this PR. Thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this upgrades some of the cops to handle numb locks, it deserves a changeling entry
61696b7
to
130c2ea
Compare
I update this PR. Thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final finishing touches and we're ready to go 🚀
130c2ea
to
1f36197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙇 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine as far as I can tell.
In this PR, corrections were made to the following internal cop additions where they were in offense.
numblock
verification for ALL the cops that checkblock
nodes rubocop#10915This PR correction of each offense for each cop in separate commits, just as we did with the original PR.
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.Enabled: true
in.rubocop.yml
.VersionAdded
indefault/config.yml
to the next minor version.If you have modified an existing cop's configuration options:
VersionChanged
inconfig/default.yml
to the next major version.