Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for RSpec/Capybara/SpecificMatcher when pseudo-classes #1361

Merged
merged 1 commit into from Sep 7, 2022

Conversation

ydah
Copy link
Member

@ydah ydah commented Aug 16, 2022

Resolve: #1351


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • [-] Added the new cop to config/default.yml.
  • [-] The cop is configured as Enabled: pending in config/default.yml.
  • [-] The cop is configured as Enabled: true in .rubocop.yml.
  • [-] The cop documents examples of good and bad code.
  • [-] The tests assert both that bad code is reported and that good code is not reported.
  • [-] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

  • [-] Set VersionChanged in config/default.yml to the next major version.

@ydah
Copy link
Member Author

ydah commented Aug 16, 2022

This CI failure is due to the addition of the following Internal cop:

@ydah
Copy link
Member Author

ydah commented Aug 16, 2022

The following PR is needed:

@ydah ydah force-pushed the fix/1351 branch 2 times, most recently from 9bafb50 to d349fc8 Compare August 30, 2022 10:49
@ydah
Copy link
Member Author

ydah commented Aug 30, 2022

Conflicts have been resolved.

@ydah ydah force-pushed the fix/1351 branch 2 times, most recently from e33a2ba to 808391d Compare September 1, 2022 10:43
Copy link
Member

@Darhazer Darhazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized I haven't submmited my review 🤦

lib/rubocop/cop/rspec/capybara/specific_matcher.rb Outdated Show resolved Hide resolved
@ydah ydah force-pushed the fix/1351 branch 2 times, most recently from 8f8e809 to a1d54b8 Compare September 1, 2022 11:02
@ydah ydah requested a review from Darhazer September 1, 2022 11:04
@ydah
Copy link
Member Author

ydah commented Sep 1, 2022

Thanks for your review! I updated this PR.

@ydah
Copy link
Member Author

ydah commented Sep 5, 2022

I updated this PR. Thank you so much.

@ydah ydah requested a review from bquorning September 5, 2022 01:18
@bquorning bquorning merged commit 83263f5 into rubocop:master Sep 7, 2022
@ydah ydah deleted the fix/1351 branch September 7, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RSpec/Capybara/SpecificMatcher] False-positive with pseudo-classes
3 participants