New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a false positive for RSpec/Capybara/SpecificMatcher
when pseudo-classes
#1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CI failure is due to the addition of the following Internal cop: |
The following PR is needed: |
ydah
force-pushed
the
fix/1351
branch
2 times, most recently
from
August 30, 2022 10:49
9bafb50
to
d349fc8
Compare
Conflicts have been resolved. |
ydah
force-pushed
the
fix/1351
branch
2 times, most recently
from
September 1, 2022 10:43
e33a2ba
to
808391d
Compare
Darhazer
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized I haven't submmited my review 🤦
ydah
force-pushed
the
fix/1351
branch
2 times, most recently
from
September 1, 2022 11:02
8f8e809
to
a1d54b8
Compare
Thanks for your review! I updated this PR. |
Darhazer
approved these changes
Sep 1, 2022
bquorning
reviewed
Sep 2, 2022
bquorning
reviewed
Sep 3, 2022
I updated this PR. Thank you so much. |
bquorning
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #1351
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml
.Enabled: pending
inconfig/default.yml
.Enabled: true
in.rubocop.yml
.VersionAdded
indefault/config.yml
to the next minor version.If you have modified an existing cop's configuration options:
VersionChanged
inconfig/default.yml
to the next major version.