[Fix #700] Fix a false positive for Rails/FilePath

changelog/fix_a_false_positive_for_rails_filepath_for_colon_separated_pathlist.md

@@ -0,0 +1 @@
+* [#700](https://github.com/rubocop/rubocop-rails/issues/700): Fix a false positive for `Rails/FilePath` when a list of paths separated by colon including Rails.root. ([@tk0miya][])

lib/rubocop/cop/rails/file_path.rb

@@ -48,8 +48,11 @@ class FilePath < Base
         def on_dstr(node)
           return unless rails_root_nodes?(node)
           return unless node.children.last.str_type?
-          return unless node.children.last.source.start_with?('.') ||
-                        node.children.last.source.include?(File::SEPARATOR)
+
+          last_child_source = node.children.last.source
+          return unless last_child_source.start_with?('.') ||
+                        last_child_source.include?(File::SEPARATOR)
+          return if last_child_source.start_with?(':')
 
           register_offense(node)
         end

spec/rubocop/cop/rails/file_path_spec.rb

@@ -122,6 +122,14 @@
         RUBY
       end
     end
+
+    context 'when concat Rails.root and colon using string interpoloation' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~'RUBY')
+          "#{Rails.root}:/foo/bar"
+        RUBY
+      end
+    end
   end
 
   context 'when EnforcedStyle is `arguments`' do
@@ -245,5 +253,13 @@
         RUBY
       end
     end
+
+    context 'when concat Rails.root and colon using string interpoloation' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~'RUBY')
+          "#{Rails.root}:/foo/bar"
+        RUBY
+      end
+    end
   end
 end