-
-
Notifications
You must be signed in to change notification settings - Fork 248
/
file_path_spec.rb
265 lines (233 loc) · 8.28 KB
/
file_path_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Rails::FilePath, :config do
context 'when EnforcedStyle is `slashes`' do
let(:cop_config) { { 'EnforcedStyle' => 'slashes' } }
context 'when using Rails.root.join with some path strings' do
it 'registers an offense' do
expect_offense(<<~RUBY)
Rails.root.join('app', 'models', 'user.rb')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'when using Rails.root.join in string interpolation of argument' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
system "rm -rf #{Rails.root.join('a', 'b.png')}"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'when using Rails.root.join in string interpolation with nothing after it' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
"#{Rails.root.join('log/production.log')}"
RUBY
end
end
context 'when using string interpolation without Rails.root' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?('/')
RUBY
end
end
context 'when using File::SEPARATOR string without Rails.root' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
"#{42}/"
RUBY
end
end
context 'when using File.join with Rails.root' do
it 'registers an offense' do
expect_offense(<<~RUBY)
File.join(Rails.root, 'app', 'models')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'when using Rails.root.join with slash separated path string' do
it 'does not register an offense' do
expect_no_offenses("Rails.root.join('app/models/goober')")
end
end
context 'when using Rails.root called by double quoted string' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
"#{Rails.root}/app/models/goober"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'when concat Rails.root and file separator ' \
'using string interpolation' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
system "rm -rf #{Rails.root}/foo/bar"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'when concat Rails.root.join and extension ' \
'using string interpolation' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
"#{Rails.root.join('tmp', user.id, 'icon')}.png"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'Rails.root is used as a method argument' do
it 'registers an offense once' do
expect_offense(<<~RUBY)
foo(bar(File.join(Rails.root, "app", "models")))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path/to')`.
RUBY
end
end
context 'Rails.root.join used as an argument' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
foo(Rails.root.join('app/models'))
RUBY
end
end
context 'Rails.root.join with a non-string argument including "/"' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
Rails.root.join("tmp", "data", index/3, "data.csv")
RUBY
end
end
context 'when string contains an interpolation followed by a period' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
puts "test #\{123\}. Hey!"
RUBY
end
end
context 'when concat Rails.root and colon using string interpoloation' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
"#{Rails.root}:/foo/bar"
RUBY
end
end
end
context 'when EnforcedStyle is `arguments`' do
let(:cop_config) { { 'EnforcedStyle' => 'arguments' } }
context 'when using Rails.root.join with some path strings' do
it 'does not register an offense' do
expect_no_offenses("Rails.root.join('app', 'models', 'user.rb')")
end
end
context 'when using Rails.root.join in string interpolation of argument' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
'system "rm -rf #{Rails.root.join(\'a\', \'b.png\')}"'
RUBY
end
end
context 'when using Rails.root.join in string interpolation with nothing after it' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
"#{Rails.root.join('log', 'production.log')}"
RUBY
end
end
context 'when using string interpolation without Rails.root' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?('/')
RUBY
end
end
context 'when using File::SEPARATOR string without Rails.root' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
"#{42}/"
RUBY
end
end
context 'when using File.join with Rails.root' do
it 'registers an offense' do
expect_offense(<<~RUBY)
File.join(Rails.root, 'app', 'models')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'when using Rails.root.join with slash separated path string' do
it 'registers an offense' do
expect_offense(<<~RUBY)
Rails.root.join('app/models/goober')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'when using Rails.root called by double quoted string' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
"#{Rails.root}/app/models/goober"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'when concat Rails.root and file separator ' \
'using string interpolation' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
system "rm -rf #{Rails.root}/foo/bar"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'when concat Rails.root.join and extension ' \
'using string interpolation' do
it 'registers an offense' do
expect_offense(<<~'RUBY')
"#{Rails.root.join('tmp', user.id, 'icon')}.png"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'Rails.root is used as a method argument' do
it 'registers an offense once' do
expect_offense(<<~RUBY)
foo(bar(File.join(Rails.root, "app", "models")))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'Rails.root.join used as an argument' do
it 'registers an offense once' do
expect_offense(<<~RUBY)
foo(Rails.root.join('app/models'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Rails.root.join('path', 'to')`.
RUBY
end
end
context 'Rails.root.join with a non-string argument including "/"' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
Rails.root.join("tmp", "data", index/3, "data.csv")
RUBY
end
end
context 'when string contains an interpolation followed by a period' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
puts "test #\{123\}. Hey!"
RUBY
end
end
context 'when concat Rails.root and colon using string interpoloation' do
it 'does not register an offense' do
expect_no_offenses(<<~'RUBY')
"#{Rails.root}:/foo/bar"
RUBY
end
end
end
end