Skip to content

Commit

Permalink
Merge pull request #263 from koic/change_unmark_autocorrect_false_fro…
Browse files Browse the repository at this point in the history
…m_performance_string_include

Unmark `AutoCorrect: false` from `Performance/StringInclude`
  • Loading branch information
koic committed Oct 30, 2021
2 parents 467b8a1 + 991a414 commit 41d3fd8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
@@ -0,0 +1 @@
* [#263](https://github.com/rubocop/rubocop-performance/pull/263): Unmark `AutoCorrect: false` from `Performance/StringInclude`. ([@koic][])
2 changes: 1 addition & 1 deletion config/default.yml
Expand Up @@ -309,9 +309,9 @@ Performance/StartWith:
Performance/StringInclude:
Description: 'Use `String#include?` instead of a regex match with literal-only pattern.'
Enabled: 'pending'
AutoCorrect: false
SafeAutoCorrect: false
VersionAdded: '1.7'
VersionChanged: '1.12'

Performance/StringReplacement:
Description: >-
Expand Down
12 changes: 1 addition & 11 deletions docs/modules/ROOT/pages/cops_performance.adoc
Expand Up @@ -1914,7 +1914,7 @@ of the variables which rubocop doesn't have.
| Yes
| Yes (Unsafe)
| 1.7
| -
| 1.12
|===

This cop identifies unnecessary use of a regex where
Expand All @@ -1940,16 +1940,6 @@ This cop's offenses are not safe to auto-correct if a receiver is nil.
'abc'.include?('ab')
----

=== Configurable attributes

|===
| Name | Default value | Configurable values

| AutoCorrect
| `false`
| Boolean
|===

== Performance/StringReplacement

|===
Expand Down

0 comments on commit 41d3fd8

Please sign in to comment.