Unmark AutoCorrect: false from Performance/StringInclude

This `AutoCorrect: false` looks like it was set when there was no way to safe autocorrect by `SafeAutocorrect: false`. Test code for the autocorrection exists. So it can be enabled by default. However, it is still unsafe because `SafeAutocorrect: false`.
rubocop · Oct 10, 2021 · 991a414 · 991a414
1 parent 51d23b2
commit 991a414
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/changelog/change_unmark_autocorrect_false_from_performance_string_include.md b/changelog/change_unmark_autocorrect_false_from_performance_string_include.md
@@ -0,0 +1 @@
+* [#263](https://github.com/rubocop/rubocop-performance/pull/263): Unmark `AutoCorrect: false` from `Performance/StringInclude`. ([@koic][])
diff --git a/config/default.yml b/config/default.yml
@@ -309,9 +309,9 @@ Performance/StartWith:
 Performance/StringInclude:
   Description: 'Use `String#include?` instead of a regex match with literal-only pattern.'
   Enabled: 'pending'
-  AutoCorrect: false
   SafeAutoCorrect: false
   VersionAdded: '1.7'
+  VersionChanged: '1.12'
 
 Performance/StringReplacement:
   Description: >-

diff --git a/docs/modules/ROOT/pages/cops_performance.adoc b/docs/modules/ROOT/pages/cops_performance.adoc
@@ -1848,7 +1848,7 @@ for receiver is multiline string.
 | Yes
 | Yes (Unsafe)
 | 1.7
-| -
+| 1.12
 |===
 
 This cop identifies unnecessary use of a regex where
@@ -1872,16 +1872,6 @@ This cop's offenses are not safe to auto-correct if a receiver is nil.
 'abc'.include?('ab')
 ----
 
-=== Configurable attributes
-
-|===
-| Name | Default value | Configurable values
-
-| AutoCorrect
-| `false`
-| Boolean
-|===
-
 == Performance/StringReplacement
 
 |===