Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow os as method parameter in default config #7465

Conversation

nijikon
Copy link
Contributor

@nijikon nijikon commented Oct 27, 2019

Add os to AllowedNames in the default configuration for cop
Naming/UncommunicativeMethodParamName in order to allow name that
is valid and it is pointless to replace it with i.e. operating_system


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…mmunicativeMethodParamName in order to allow name that is valid and it is pointless to replace it with i.e. `operating_system`
@nijikon nijikon force-pushed the allow-os-in-naming-uncommunicative-method-param-name branch from efa73ab to 5ec0199 Compare October 27, 2019 16:32
@nijikon nijikon marked this pull request as ready for review October 27, 2019 16:46
@bbatsov bbatsov merged commit 694d4a9 into rubocop:master Oct 27, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 27, 2019

Thanks!

@nijikon nijikon deleted the allow-os-in-naming-uncommunicative-method-param-name branch October 28, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants