Skip to content

Commit

Permalink
Add os to AllowedNames in default configuration for cop Naming/Unco…
Browse files Browse the repository at this point in the history
…mmunicativeMethodParamName (#7465)
  • Loading branch information
nijikon authored and bbatsov committed Oct 27, 2019
1 parent 9b48a4a commit 694d4a9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -12,6 +12,7 @@

### Changes

* [#7465](https://github.com/rubocop-hq/rubocop/pull/7465): Add `os` to allowed names of `Naming/UncommunicativeMethodParamName` cop in default config. ([@nijikon][])
* [#7446](https://github.com/rubocop-hq/rubocop/issues/7446): Add `merge` to list of non-mutating methods. ([@cstyles][])
* [#7077](https://github.com/rubocop-hq/rubocop/issues/7077): Rename `Unneeded*` cops to `Redundant*` (e.g., `Style/UnneededPercentQ` becomes `Style/RedundantPercentQ`). ([@scottmatthewman][])

Expand Down
1 change: 1 addition & 0 deletions config/default.yml
Expand Up @@ -2075,6 +2075,7 @@ Naming/UncommunicativeMethodParamName:
- at
- ip
- db
- os
# Blacklisted names that will register an offense
ForbiddenNames: []

Expand Down
2 changes: 1 addition & 1 deletion manual/cops_naming.md
Expand Up @@ -663,7 +663,7 @@ Name | Default value | Configurable values
--- | --- | ---
MinNameLength | `3` | Integer
AllowNamesEndingInNumbers | `true` | Boolean
AllowedNames | `io`, `id`, `to`, `by`, `on`, `in`, `at`, `ip`, `db` | Array
AllowedNames | `io`, `id`, `to`, `by`, `on`, `in`, `at`, `ip`, `db`, `os` | Array
ForbiddenNames | `[]` | Array

## Naming/VariableName
Expand Down

0 comments on commit 694d4a9

Please sign in to comment.