Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow os as method parameter in default config #7465

Merged
merged 1 commit into from Oct 27, 2019
Merged

Allow os as method parameter in default config #7465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -12,6 +12,7 @@

### Changes

* [#7465](https://github.com/rubocop-hq/rubocop/pull/7465): Add `os` to allowed names of `Naming/UncommunicativeMethodParamName` cop in default config. ([@nijikon][])
* [#7446](https://github.com/rubocop-hq/rubocop/issues/7446): Add `merge` to list of non-mutating methods. ([@cstyles][])
* [#7077](https://github.com/rubocop-hq/rubocop/issues/7077): Rename `Unneeded*` cops to `Redundant*` (e.g., `Style/UnneededPercentQ` becomes `Style/RedundantPercentQ`). ([@scottmatthewman][])

Expand Down
1 change: 1 addition & 0 deletions config/default.yml
View file
Open in desktop
Expand Up @@ -2075,6 +2075,7 @@ Naming/UncommunicativeMethodParamName:
- at
- ip
- db
- os
# Blacklisted names that will register an offense
ForbiddenNames: []

Expand Down
2 changes: 1 addition & 1 deletion manual/cops_naming.md
View file
Open in desktop
Expand Up @@ -663,7 +663,7 @@ Name | Default value | Configurable values
--- | --- | ---
MinNameLength | `3` | Integer
AllowNamesEndingInNumbers | `true` | Boolean
AllowedNames | `io`, `id`, `to`, `by`, `on`, `in`, `at`, `ip`, `db` | Array
AllowedNames | `io`, `id`, `to`, `by`, `on`, `in`, `at`, `ip`, `db`, `os` | Array
ForbiddenNames | `[]` | Array

## Naming/VariableName
Expand Down