-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builds targeting numpy 1.22 #132
Open
jack-pappas
wants to merge
5
commits into
master
Choose a base branch
from
maint/add-numpy-1_22-builds
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a1bba50
Add builds targeting numpy 1.22 now that numba 0.55.2 supports it.
jackpappasSIG 3f884a3
Allow numpy revision to float to the latest within a given minor vers…
jackpappasSIG 29576f0
One more fix for numpy 1.22 builds.
jackpappasSIG 28cc032
Hopefully the last fix for numpy 1.22 builds.
jackpappasSIG 5695f14
Third time's a charm, hopefully.
jackpappasSIG File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ jobs: | |
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
python -m pip install numpy==1.21 | ||
python -m pip install numpy==1.22 | ||
python -m pip install riptable | ||
working-directory: ${{ env.working-directory }} | ||
- name: Create Cmake build directory | ||
|
@@ -88,7 +88,7 @@ jobs: | |
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
python -m pip install numpy==1.21 | ||
python -m pip install numpy==1.22 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs |
||
python -m pip install riptable | ||
working-directory: ${{ env.working-directory }} | ||
- name: Create Cmake build directory | ||
|
@@ -208,3 +208,49 @@ jobs: | |
build/test/riptide_test/riptide_test | ||
build/test/riptide_python_test/riptide_python_test | ||
working-directory: ${{ env.working-directory }} | ||
|
||
build-cmake-ubuntu-122: | ||
|
||
runs-on: ${{ matrix.os }} | ||
env: | ||
working-directory: ./ | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest] | ||
python-version: ['3.10'] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
submodules: recursive | ||
# Set fetch-depth to 0 so all history is retrieved; this is needed so we get the git tags | ||
# which we use for setting the package version (via setuptools-scm). | ||
fetch-depth: 0 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
python -m pip install numpy==1.22 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here (would be nice to tidy up the DRYness here at some point) |
||
python -m pip install riptable | ||
working-directory: ${{ env.working-directory }} | ||
- name: Create Cmake build directory | ||
run: | | ||
cmake -E make_directory "build" | ||
working-directory: ${{ env.working-directory }} | ||
- name: Setup CMake Relase configuration | ||
run: | | ||
cmake -E chdir "build" cmake -DCMAKE_BUILD_TYPE=Release "-DRIPTIDE_PYTHON_VER=${{ matrix.python-version }}" ../ | ||
working-directory: ${{ env.working-directory }} | ||
- name: Build Release via CMake | ||
run: | | ||
cmake --build "build" --config Release | ||
working-directory: ${{ env.working-directory }} | ||
- name: Run the Release tests and benchmarks | ||
run: | | ||
build/bench/riptide_bench/riptide_bench/riptide_bench | ||
build/test/riptide_test/riptide_test | ||
build/test/riptide_python_test/riptide_python_test | ||
working-directory: ${{ env.working-directory }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these may also need to use the
numpy=1.22.*
syntax in order to pick up the most recent minor release.