Add builds targeting numpy 1.22 #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/native_sanity.yml
Outdated
| @@ -35,7 +35,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| python -m pip install numpy==1.21 | |||
| python -m pip install numpy==1.22 | |||
There was a problem hiding this comment.
these may also need to use the numpy=1.22.* syntax in order to pick up the most recent minor release.
.github/workflows/native_sanity.yml
Outdated
| @@ -88,7 +88,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| python -m pip install numpy==1.21 | |||
| python -m pip install numpy==1.22 | |||
There was a problem hiding this comment.
This needs 1.22.*
.github/workflows/native_sanity.yml
Outdated
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install numpy==1.22 |
There was a problem hiding this comment.
and here (would be nice to tidy up the DRYness here at some point)
|
The native build breaks happen in master as well. Something changed in the Windows environment that no longer compiles for Debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numba 0.55.2 was recently released with compatibility for numpy 1.22; that means riptide_cpp can now add builds targeting numpy 1.22 since riptable will now be able to use it.